Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http client: reuse transport previously created in NewClient #1991

Closed
wants to merge 2 commits into from

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 22, 2015

In case #1986 (comment) is a bug. Which is more likely, since the err "request cancelled" is supposed to be printed out https://github.com/ipfs/go-ipfs/blob/master/commands/http/client.go#L134.

@jbenet jbenet added the status/in-progress In progress label Nov 22, 2015
@rht rht added the RFCR label Nov 22, 2015
@rht
Copy link
Contributor Author

rht commented Nov 22, 2015

Which err, e.g. Error: Post http://127.0.0.1:5001/api/v0/get?arg=QmQv4YQNmRPuTTHs4AgBhKEFDdN7eQYeTbSmr8JVWVfury&encoding=json&stream-channels=true: net/http: request canceled needs to be humanized, related #560.

@whyrusleeping
Copy link
Member

mmm. i think a lot of this was from before we used go1.5 http tralers to make things work right. We can probably get away with removing that cruft now

@rht rht force-pushed the reuse-transport branch 3 times, most recently from 019cf0e to 55abd53 Compare November 22, 2015 09:47
@rht
Copy link
Contributor Author

rht commented Nov 22, 2015

Closing, since tr.CancelRequest is going to be replaced with the *http.Request.Cancel channel anyway, which has been around for ages (since go1.4).

@rht rht closed this Nov 22, 2015
@jbenet jbenet removed the status/in-progress In progress label Nov 22, 2015
@rht rht mentioned this pull request Nov 22, 2015
1 task
@Kubuxu Kubuxu deleted the reuse-transport branch February 27, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants