Use 'dag' forall namespace import prefixes of merkledag #1983
Conversation
|
Also a small issue (yet naming is one out of two hard problems in cs?), 'n','nd','node' are used interchangeably for core.IpfsNode and dag.Node (not to mention that both use of "node"). Would it be more grep-able if the former's shorthand is changed to 'in'/'inode'? |
|
i don't like the connotation of calling the core.IpfsNode an inode, i agree we should be consistent though. maybe |
|
this PR LGTM, mind rebasing on top of latest 0.4.0? |
|
Rebased. Both 'in' and 'inode' already have connotation that may confuse things, it definitely should be something else, it's just that I haven't come up a shorthand yet. |
|
@rht i'm 99% certain the circle sharness test failures have nothing to do with this PR. but do you have any idea what might be causing them? |
|
Travis looks similar, doesn't it? Some of these look hairy. I'm also seeing the same errors in #1987. |
|
ctrl+f "not ok" |
|
The stalled os x build (errs not being output-ed?) might have an explanation in the circle-ci errs. |
|
could it be something in master? |
|
@rht was it the watermark repo gc? i recall some pr recently being the first. i dont think it's travis-ci here. |
|
certainly in this run it was: https://travis-ci.org/ipfs/go-ipfs/jobs/92377814#L5059-L5060 |
Yes but there is less merge conflict in 0.4.0. Also, here is another naming clash that might cause confusion commands.Context and context.Context. |
|
In general, this PR LGTM. i think we should still solve the random failures on master + rebase dev0.4.0 on top of that, and this on top of dev0.4.0. at some point we let through something that randomly breaks and now we're paying the price. :( maybe someone could try bisecting it? |
|
Rebased. In this case, test fails are orthogonal to the possible errs caused by import errs. |
ghost
added
the
whyrusleeping
force-pushed
the
dev0.4.0
branch
2 times, most recently
from
68b9745
to
b0a8591
Compare
License: MIT Signed-off-by: Lars Gierth <[email protected]>
whyrusleeping
force-pushed
the
dev0.4.0
branch
from
cf514d8
to
3224ae0
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Richard Littauer <[email protected]>
See ipfs#1296 License: MIT Signed-off-by: Richard Littauer <[email protected]>
Need to publish to https://github.com/ipfs/npm-go-ipfs cc @whyrusleeping this did not happen for 0.3.11
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Thomas Gardner <[email protected]>
Because this requirement is not listed anywhere, but was mentioned in ipfs#2202 (comment). License: MIT Signed-off-by: Richard Littauer <[email protected]>
Added squash note to contribute.md
trivial: fix `ipfs update` error message
Gateway: add support for HTTP OPTIONS request type
License: MIT Signed-off-by: Richard Littauer <[email protected]>
See ipfs#2180 (comment) License: MIT Signed-off-by: Richard Littauer <[email protected]>
This allows a path (/ipfs/foo/bar) to be separated between its head (/ipfs/foo) and its tail (bar). License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
This is done by skipping the step of resolving the final segment in the path to a DAG node; instead preferring to look at the second-to-last segmenet's links. License: MIT Signed-off-by: Stephen Whitmore <[email protected]>
This fixes ipfs#1083, ipfs#2000. N.B. The JSON package developers see no trailing newline as a feature; it allows marshalled JSON to be embedded inside more JSON.[0] -- [0] https://golang.org/pkg/encoding/json/ License: MIT Signed-off-by: Thomas Gardner <[email protected]>
Resolve paths in 'pin rm' /wo network lookup
fix ipfs#1083: Append a newline to `ipfs id` output.
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Thomas Gardner <[email protected]>
Makefile: add PHONY targets and a help message
Added small note about shutdown
Capitalized beginning of line messages, added periods
License: MIT Signed-off-by: rht <[email protected]>
License: MIT Signed-off-by: Richard Littauer <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
s/retreiving/retrieving/g
finally add changelog for v0.3.11
|
@rht mind redoing this on latest master? would be good to have a bit of consistency there |
|
This could have been merged before dev0.4.0 was merged into master. |
License: MIT Signed-off-by: rht <[email protected]>
|
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
Oldest code uses 'merkledag'. Slightly older code uses 'mdag'. Most recent code uses 'dag'.