Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to bitswap + dht #155

Merged
merged 63 commits into from
Oct 19, 2014
Merged

Some fixes to bitswap + dht #155

merged 63 commits into from
Oct 19, 2014

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Oct 11, 2014

No description provided.

@jbenet jbenet added the status/in-progress In progress label Oct 11, 2014
@jbenet
Copy link
Member Author

jbenet commented Oct 12, 2014

cc @whyrusleeping lmk thoughts here. prob not fully ready yet-- will check things out with your new cmd

@@ -88,8 +84,16 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error)
for iiiii := range peersToQuery {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm.... wat?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, yeah. I'll fix that

@jbenet
Copy link
Member Author

jbenet commented Oct 19, 2014

jbenet: TestConnectCollision fails for me

So, it was the "which connection picked" problem. So, I implemented MultiConn, and it works now. And i also solved all sorts of ugly connection startup/teardown problems we had. Fixed most things detailed in #187 (at least for now), using my new and shiny ContextCloser.

(tests on travis seem to be very time dependent. particularly things waiting for connection teardowns. seems like we'll need to just bump all timeouts by 2-3 orders of magnitude :/)

@jbenet
Copy link
Member Author

jbenet commented Oct 19, 2014

@whyrusleeping pls see if it fails for you still, and if not, let's merge this.

need to switch away from timing tests. its very annoying.
Should use proper go sync, as in
https://www.youtube.com/watch?v=ndmB0bj7eyw
@whyrusleeping
Copy link
Member

5/5 runs passed for me! LGTM

jbenet added a commit that referenced this pull request Oct 19, 2014
Some fixes to bitswap + dht
@jbenet jbenet merged commit c8ea913 into master Oct 19, 2014
@jbenet jbenet removed the status/in-progress In progress label Oct 19, 2014
@jbenet jbenet deleted the netfixes branch October 19, 2014 23:52
@jbenet
Copy link
Member Author

jbenet commented Oct 19, 2014

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
remove redundant error check
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
* add a flag to enable the hole punching service
* chore: omitempty EnableHolePunching

Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
…pfs#155)

* add a flag to enable the hole punching service
* chore: omitempty EnableHolePunching

Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…pfs#155)

* add a flag to enable the hole punching service
* chore: omitempty EnableHolePunching

Co-authored-by: Marcin Rataj <[email protected]>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…pfs#155)

* add a flag to enable the hole punching service
* chore: omitempty EnableHolePunching

Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants