Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AutoTLS): opt-in WSS certs from p2p-forge at libp2p.direct #10521
feat(AutoTLS): opt-in WSS certs from p2p-forge at libp2p.direct #10521
Changes from 7 commits
ce6d09d
ecfc8d9
fe307da
bfc73d0
7c9842e
bef0a21
06708d8
af543af
946298b
d5994c1
7ae58bc
4889612
a038637
538c9bb
b306f56
9bd8ebb
21b5c88
7eeda1b
99b7757
e6e0b7a
ed7e201
e51d907
73c3fd3
e68493a
bcabbb4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug in cluster logs ("error while checking storage for updated ARI; updating ARI now"):
I suspect this is another race condition where certmanager things (like location
.local/share/certmagic/
) are initialized with default config before our config is applied (same problem as the logger).Will look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential fix in e51d907 and ipshipyard/p2p-forge@f599f48.
TLDR is that
certmagic.NewDefault
should be used only for prototyping, or if one is ok with default storage location and logger. Using dedicated cache and avoiding callingcertmagic.NewDefault
should remove surface for race condition in setting storage paths AFTER maintenance job is started.I'm going to deploy to collab cluster, let it run over night and see if ARI error is gone.
Update: so far the fix looks good, renewal check does not produce error anymore:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the error seems to be gone. Considering this resolved, but keeping this open for visibility.