Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): preserve hostname specified with --api in http request headers #10497

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Aug 28, 2024

Note: It is necessary to keep the call to resolveAddr to check for a resolvable address, otherwise the host is reported as offline when the address should be reported as not resolvable.

Closes #10232

Thank you @softwareplumber for this solution.

- Replaces PR #10233
- Add test to check for hostname in HTTP header
@gammazero gammazero requested a review from a team as a code owner August 28, 2024 16:11
docs/changelogs/v0.30.md Outdated Show resolved Hide resolved
@lidel lidel changed the title Preserve hostname specified with --api in http request headers fix(cli): preserve hostname specified with --api in http request headers Aug 28, 2024
@gammazero gammazero merged commit 5fe9604 into master Aug 28, 2024
14 checks passed
@gammazero gammazero deleted the feat/cmds/use-hostname branch August 28, 2024 17:03
lidel pushed a commit that referenced this pull request Aug 28, 2024
…ers (#10497)

Preserve hostname specified with --api in http request headers

- Replaces PR #10233
- Add test to check for hostname in HTTP header
- Update docs/changelogs/v0.30.md

(cherry picked from commit 5fe9604)
@lidel lidel mentioned this pull request Aug 28, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants