Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad links via IPNS mountpoint #7246

Closed
neededanametoreportbug opened this issue Apr 29, 2020 · 1 comment · Fixed by #7331
Closed

bad links via IPNS mountpoint #7246

neededanametoreportbug opened this issue Apr 29, 2020 · 1 comment · Fixed by #7331
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up regression topic/fuse Topic fuse topic/ipns Topic ipns

Comments

@neededanametoreportbug
Copy link

ipfs version --all
go-ipfs version: 0.5.0
Repo version: 9
System version: amd64/linux
Golang version: go1.13.10

Trying to access content via the IPNS filesystem mount point results in broken links to the IPFS filesystem mount point, except for the local peer.

eg:
ipfs mount

IPFS mounted at: /ipfs
IPNS mounted at: /ipns

ipfs name resolve ipfs.io

/ipfs/bafybeih2idmvr2uum3k7btt6mjxfzeb7ank5g6zkmrfbxkvu6ownzbrtky

cd /ipns/ipfs.io

bash: cd: /ipns/ipfs.io: No such file or directory

ls /ipns/ipfs.io

lr-xr-xr-x. 1 root root 0 Apr 29 19:26 /ipfs.io -> /ipfs//ipfs/

Looks like the link has an unnecessary "/ipfs/" added to the destination

However local peer is visible via the ipns mount point though, eg :/ipns/local and /ipns/[peer id]
@neededanametoreportbug neededanametoreportbug added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Apr 29, 2020
@hsanjuan
Copy link
Contributor

I can reproduce this and it's a regression from v0.4.23. However I am not sure when it happened.

@Stebalien Stebalien added P2 Medium: Good to have, but can wait until someone steps up regression topic/fuse Topic fuse topic/ipns Topic ipns and removed need/triage Needs initial labeling and prioritization labels May 19, 2020
Stebalien added a commit that referenced this issue May 20, 2020
@Stebalien
fix: correctly trim resolved IPNS addresses
abcedea 
fixes #7246
@Stebalien Stebalien mentioned this issue May 20, 2020
Merged
Stebalien added a commit that referenced this issue May 20, 2020
@Stebalien
fix: correctly trim resolved IPNS addresses
391d345 
fixes #7246
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix: correctly trim resolved IPNS addresses
15dea08 
fixes ipfs#7246
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: correctly trim resolved IPNS addresses
0983893 
fixes ipfs#7246
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: correctly trim resolved IPNS addresses
2dafc20 
fixes ipfs#7246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up regression topic/fuse Topic fuse topic/ipns Topic ipns
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly trim resolved IPNS addresses ipfs/kubo
3 participants
@Stebalien @hsanjuan @neededanametoreportbug