Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway doesn’t load .eth domains from Host: header #6699

Closed
parkan opened this issue Oct 7, 2019 · 0 comments · Fixed by #6700
Closed

gateway doesn’t load .eth domains from Host: header #6699

parkan opened this issue Oct 7, 2019 · 0 comments · Fixed by #6700
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@parkan
Copy link

parkan commented Oct 7, 2019 •
edited
Loading

Version information:

master

Description:

the changes in #6448 should have allowed us to resolve .eth domains even though it’s not a “real” TLD, but this still fails when the name is passed in Host: header

Works

$ curl 35.241.8.114/ipns/almonit.eth/

Does Not Work

$ curl 35.241.8.114 --header “Host:almonit.eth”

as discussed w @Stebalien, would be A+ to fix this before DevCon starts properly
@parkan parkan added the kind/bug A bug in existing code (including security flaws) label Oct 7, 2019
@parkan parkan changed the title gateway doesn gateway doesn’t load .eth domains from Host: header Oct 7, 2019
Stebalien added a commit that referenced this issue Oct 7, 2019
@Stebalien
fix(resolve): correctly handle .eth domains
a57c759 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes #6699
@Stebalien Stebalien mentioned this issue Oct 7, 2019
Merged
Stebalien added a commit that referenced this issue Oct 7, 2019
@Stebalien
fix(resolve): correctly handle .eth domains
1e8b367 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes #6699
Stebalien added a commit that referenced this issue Oct 7, 2019
@Stebalien
fix(resolve): correctly handle .eth domains
d5f22c2 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes #6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
e9ee10e 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
f80497d 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
8f0c800 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
35cd513 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
96616f1 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix(resolve): correctly handle .eth domains
241a207 
This should have been handled down inside the DNSLink resolver. Otherwise, we'll
break any name happens to end in `.eth`.

also fixes ipfs#6699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(resolve): correctly handle .eth domains ipfs/kubo
1 participant
@parkan