Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http api Identify with HEAD request #625

Closed
travisperson opened this issue Jan 23, 2015 · 4 comments
Closed

http api Identify with HEAD request #625

travisperson opened this issue Jan 23, 2015 · 4 comments
Labels
exp/novice Someone with a little familiarity can pick up topic/gateway Topic gateway

Comments

@travisperson
Copy link
Member

I wasn't able to find a really easy way to determine if the service running on port 5001 was the ipfs daemon. It might be beneficial to have the API respond to a request to HEAD requests with something to identify itself.

curl -I http://127.0.0.1:5001/ipfs/
HTTP/1.1 400 Bad Request
Date: Fri, 23 Jan 2015 06:06:42 GMT
Content-Length: 38
Content-Type: text/plain; charset=utf-8
Server: Ipfs-Daemon/0.1.7
@jbenet
Copy link
Member

jbenet commented Jan 23, 2015

👍 on the Server header! We should use the same ipfs-agent string: go-ipfs/<version>

@jbenet
Copy link
Member

jbenet commented Mar 28, 2015

Would be good to still:

  • include the server header (should be the go-ipfs agent)

The identification can now happen by going to /version. example: http://localhost:5001/version

Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Dec 31, 2015
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Dec 31, 2015
Resolves ipfs#625

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
@whyrusleeping
Copy link
Member

HEAD requests work now, we can close this after @Kubuxu's PR merges

@daviddias
Copy link
Member

Security wise, it is a bad practice to announce the running service (and version) on HTTP headers or any kind of banners

Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 4, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 4, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 4, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 5, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 5, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 6, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 12, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 20, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
Kubuxu added a commit to Kubuxu/go-ipfs that referenced this issue Jan 20, 2016
Resolves ipfs#625
Included in tests.

License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera <[email protected]>
@RichardLitt RichardLitt added the exp/novice Someone with a little familiarity can pick up label Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up topic/gateway Topic gateway
Projects
None yet
Development

No branches or pull requests

5 participants