Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(routing/dht) data race #270

Closed
btc opened this issue Nov 5, 2014 · 10 comments
Closed

bug(routing/dht) data race #270

btc opened this issue Nov 5, 2014 · 10 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@btc
Copy link
Contributor

btc commented Nov 5, 2014

Full gist here: https://gist.github.com/maybebtc/7da7d507bd800a856406

Ran tests under the race detector. Discovered this.

�[0;37m01:52:34.238 �[31mERROR �[0;34m     swarm: �[0mFailed to listen on: /ip4/127.0.0.1/tcp/2222 - listen tcp 127.0.0.1:2222: bind: address already in use �[0;37mconn.go:27�[0m
==================
WARNING: DATA RACE
Write by goroutine 14:
  sync.raceWrite()
      /usr/local/opt/go/libexec/src/pkg/sync/race.go:41 +0x35
  sync.(*WaitGroup).Wait()
      /usr/local/opt/go/libexec/src/pkg/sync/waitgroup.go:122 +0x176
  github.com/jbenet/go-ipfs/util/ctxcloser.(*contextCloser).closeLogic()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:171 +0xba
  github.com/jbenet/go-ipfs/util/ctxcloser.*contextCloser.(github.com/jbenet/go-ipfs/util/ctxcloser.closeLogic)·fm()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:161 +0x33
  sync.(*Once).Do()
      /usr/local/opt/go/libexec/src/pkg/sync/once.go:40 +0xb1

Previous read by goroutine 11:
  sync.raceRead()
      /usr/local/opt/go/libexec/src/pkg/sync/race.go:37 +0x35
  sync.(*WaitGroup).Add()
      /usr/local/opt/go/libexec/src/pkg/sync/waitgroup.go:60 +0xbe
  github.com/jbenet/go-ipfs/util/ctxcloser.(*contextCloser).closeOnContextDone()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:179 +0x4b
@btc btc added the kind/bug A bug in existing code (including security flaws) label Nov 5, 2014
@btc
Copy link
Contributor Author

btc commented Nov 5, 2014 

==================
WARNING: DATA RACE
Write by goroutine 70:
  sync.raceWrite()
      /usr/local/opt/go/libexec/src/pkg/sync/race.go:41 +0x35
  sync.(*WaitGroup).Wait()
      /usr/local/opt/go/libexec/src/pkg/sync/waitgroup.go:122 +0x176
  github.com/jbenet/go-ipfs/util/ctxcloser.(*contextCloser).closeLogic()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:171 +0xba
  github.com/jbenet/go-ipfs/util/ctxcloser.*contextCloser.(github.com/jbenet/go-ipfs/util/ctxcloser.closeLogic)·fm()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:161 +0x33
  sync.(*Once).Do()
      /usr/local/opt/go/libexec/src/pkg/sync/once.go:40 +0xb1

Previous read by goroutine 196:
  sync.raceRead()
      /usr/local/opt/go/libexec/src/pkg/sync/race.go:37 +0x35
  sync.(*WaitGroup).Add()
      /usr/local/opt/go/libexec/src/pkg/sync/waitgroup.go:60 +0xbe
  github.com/jbenet/go-ipfs/util/ctxcloser.(*contextCloser).closeOnContextDone()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/ctxcloser/closer.go:179 +0x4b
  runtime.gosched0()
      /usr/local/opt/go/libexec/src/pkg/runtime/proc.c:1436 +0xaf
  crypto/elliptic.p256Square()
      /usr/local/opt/go/libexec/src/pkg/crypto/elliptic/p256.go:550 +0xcbd
  crypto/elliptic.p256Invert()
      /usr/local/opt/go/libexec/src/pkg/crypto/elliptic/p256.go:698 +0x61f
  crypto/elliptic.p256PointToAffine()
      /usr/local/opt/go/libexec/src/pkg/crypto/elliptic/p256.go:1067 +0x61
  crypto/elliptic.p256ToAffine()
      /usr/local/opt/go/libexec/src/pkg/crypto/elliptic/p256.go:1078 +0x85
  crypto/elliptic.p256Curve.ScalarMult()
      /usr/local/opt/go/libexec/src/pkg/crypto/elliptic/p256.go:77 +0x17d
  github.com/jbenet/go-ipfs/crypto.func·001()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/crypto/key.go:126 +0x449
  github.com/jbenet/go-ipfs/crypto/spipe.(*SecurePipe).handshake()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/crypto/spipe/handshake.go:181 +0x1c00
  github.com/jbenet/go-ipfs/crypto/spipe.NewSecurePipe()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/crypto/spipe/pipe.go:50 +0x1ee
  github.com/jbenet/go-ipfs/net/conn.(*secureConn).secureHandshake()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/net/conn/secure_conn.go:64 +0x38c
  github.com/jbenet/go-ipfs/net/conn.newSecureConn()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/net/conn/secure_conn.go:37 +0x320
  github.com/jbenet/go-ipfs/net/conn.func·005()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/net/conn/listen.go:67 +0x32b

@jbenet
Copy link
Member

jbenet commented Nov 5, 2014

the second looks to be in spipe. what's the first one on?

@jbenet
Copy link
Member

jbenet commented Nov 5, 2014

stack traces look cut off

@btc
Copy link
Contributor Author

btc commented Nov 5, 2014

@jbenet Did you see the full gist? https://gist.github.com/maybebtc/7da7d507bd800a856406

edit: i should've displayed the link more prominently

@jbenet
Copy link
Member

jbenet commented Nov 5, 2014

Btw, I also got:

==================
WARNING: DATA RACE
Write by goroutine 538:
  github.com/jbenet/go-ipfs/exchange/bitswap.TestSendToWantingPeer()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap_test.go:152 +0x46
  testing.tRunner()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:422 +0x10f

Previous read by goroutine 572:
  github.com/jbenet/go-ipfs/blocks.NewBlockWithHash()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/blocks/blocks.go:26 +0x60
  github.com/jbenet/go-ipfs/blockstore.(*blockstore).Get()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/blockstore/blockstore.go:40 +0x227
  github.com/jbenet/go-ipfs/exchange/bitswap.(*bitswap).ReceiveMessage()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:182 +0xbd0
  github.com/jbenet/go-ipfs/exchange/bitswap/testnet.(*networkClient).ReceiveMessage()
      <autogenerated>:6 +0xff
  github.com/jbenet/go-ipfs/exchange/bitswap/testnet.(*network).SendRequest()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/testnet/network.go:119 +0x35d
  github.com/jbenet/go-ipfs/exchange/bitswap/testnet.(*networkClient).SendRequest()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/testnet/network.go:163 +0x118
  github.com/jbenet/go-ipfs/exchange/bitswap.func·002()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:100 +0x343
  runtime.gosched0()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/runtime/proc.c:1436 +0xaf
  github.com/jbenet/go-ipfs/routing/mock.func·001()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/routing/mock/routing.go:65 +0x10e

Goroutine 538 (running) created at:
  testing.RunTests()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:504 +0xb46
  testing.Main()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:435 +0xa2
  main.main()
      github.com/jbenet/go-ipfs/exchange/bitswap/_test/_testmain.go:55 +0xdc

Goroutine 572 (finished) created at:
  github.com/jbenet/go-ipfs/exchange/bitswap.func·003()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:114 +0x526
==================

==================
WARNING: DATA RACE
Write by goroutine 6:
  github.com/jbenet/go-ipfs/fuse/ipns.func·003()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:220 +0x53
  github.com/jbenet/go-ipfs/fuse/ipns.TestFastRepublish()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:299 +0x1277
  testing.tRunner()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:422 +0x10f

Previous read by goroutine 82:
  github.com/jbenet/go-ipfs/fuse/ipns.func·004()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:248 +0x5c
  runtime.gosched0()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/runtime/proc.c:1436 +0xaf
  math/big.nat.div()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/math/big/nat.go:506 +0x129
  math/big.(*Int).QuoRem()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/math/big/int.go:224 +0x11d
  math/big.(*Int).GCD()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/math/big/int.go:631 +0x299
  math/big.(*Int).ModInverse()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/math/big/int.go:740 +0x84
  crypto/rsa.(*PrivateKey).Precompute()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/crypto/rsa/rsa.go:359 +0x46e
  crypto/rsa.GenerateMultiPrimeKey()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/crypto/rsa/rsa.go:216 +0x8f4
  crypto/rsa.GenerateKey()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/crypto/rsa/rsa.go:126 +0x63
  github.com/jbenet/go-ipfs/crypto.GenerateKeyPair()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/crypto/key.go:77 +0xbb
  github.com/jbenet/go-ipfs/core.NewMockNode()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/core/mock.go:20 +0x79
  github.com/jbenet/go-ipfs/fuse/ipns.setupIpnsTest()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:67 +0x6d
  github.com/jbenet/go-ipfs/fuse/ipns.TestAppendFile()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:164 +0x4e
  testing.tRunner()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:422 +0x10f

Goroutine 6 (running) created at:
  testing.RunTests()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:504 +0xb46
  testing.Main()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:435 +0xa2
  main.main()
      github.com/jbenet/go-ipfs/fuse/ipns/_test/_testmain.go:59 +0xdc

Goroutine 82 (running) created at:
  github.com/jbenet/go-ipfs/fuse/ipns.TestFastRepublish()
      /Users/jbenet/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_test.go:252 +0xaf3
  testing.tRunner()
      /usr/local/Cellar/go/1.3/libexec/src/pkg/testing/testing.go:422 +0x10f
==================

@btc
Copy link
Contributor Author

btc commented Nov 5, 2014

found 3 more in the fuse/ipns package

unable to reproduce to get the full trace

1

WARNING: DATA RACE
Read by goroutine 64:
  github.com/jbenet/go-ipfs/merkledag.(*Node).Encoded()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/coding.go:76 +0x7e
  github.com/jbenet/go-ipfs/merkledag.(*Node).Multihash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:144 +0x66
  github.com/jbenet/go-ipfs/merkledag.(*Node).Key()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:154 +0x5b
  github.com/jbenet/go-ipfs/merkledag.(*dagService).Add()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:181 +0x72
  github.com/jbenet/go-ipfs/merkledag.(*dagService).AddRecursive()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:204 +0x67
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).republishRoot()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:398 +0x1f3
  github.com/jbenet/go-ipfs/fuse/ipns.(*Republisher).Run()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/repub_unix.go:36 +0x222

Previous write by goroutine 78:
  github.com/jbenet/go-ipfs/merkledag.(*Node).Encoded()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/coding.go:79 +0x161
  github.com/jbenet/go-ipfs/merkledag.(*Node).Multihash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:144 +0x66
  github.com/jbenet/go-ipfs/path.(*Resolver).ResolveLinks()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/path/path.go:82 +0x281
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).Lookup()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:249 +0x29e
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs.(*serveConn).serve()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs/serve.go:871 +0x63cf

2

==================
==================
WARNING: DATA RACE
Read by goroutine 64:
  github.com/jbenet/go-ipfs/merkledag.(*Node).Multihash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:149 +0xc3
  github.com/jbenet/go-ipfs/merkledag.(*Node).Key()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:154 +0x5b
  github.com/jbenet/go-ipfs/merkledag.(*dagService).Add()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:181 +0x72
  github.com/jbenet/go-ipfs/merkledag.(*dagService).AddRecursive()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:204 +0x67
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).republishRoot()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:398 +0x1f3
  github.com/jbenet/go-ipfs/fuse/ipns.(*Republisher).Run()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/repub_unix.go:36 +0x222

Previous write by goroutine 78:
  github.com/jbenet/go-ipfs/merkledag.(*Node).Encoded()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/coding.go:82 +0x244
  github.com/jbenet/go-ipfs/merkledag.(*Node).Multihash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:144 +0x66
  github.com/jbenet/go-ipfs/path.(*Resolver).ResolveLinks()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/path/path.go:82 +0x281
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).Lookup()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:249 +0x29e
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs.(*serveConn).serve()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs/serve.go:871 +0x63cf

3

WARNING: DATA RACE
Read by goroutine 64:
  runtime.slicebytetostring()
      /private/tmp/go-0Pxw5f/go/src/pkg/runtime/string.goc:287 +0x0
  github.com/jbenet/go-ipfs/merkledag.(*Node).Key()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:155 +0xa0
  github.com/jbenet/go-ipfs/merkledag.(*dagService).Add()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:181 +0x72
  github.com/jbenet/go-ipfs/merkledag.(*dagService).AddRecursive()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:204 +0x67
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).republishRoot()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:398 +0x1f3
  github.com/jbenet/go-ipfs/fuse/ipns.(*Republisher).Run()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/repub_unix.go:36 +0x222

Previous write by goroutine 78:
  runtime.copy()
      /private/tmp/go-0Pxw5f/go/src/pkg/runtime/slice.goc:136 +0x0
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multihash.Encode()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multihash/multihash.go:138 +0x363
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multihash.Sum()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-multihash/sum.go:44 +0x4f9
  github.com/jbenet/go-ipfs/util.Hash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/util/key.go:101 +0x92
  github.com/jbenet/go-ipfs/merkledag.(*Node).Encoded()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/coding.go:82 +0x20f
  github.com/jbenet/go-ipfs/merkledag.(*Node).Multihash()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/merkledag/merkledag.go:144 +0x66
  github.com/jbenet/go-ipfs/path.(*Resolver).ResolveLinks()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/path/path.go:82 +0x281
  github.com/jbenet/go-ipfs/fuse/ipns.(*Node).Lookup()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/fuse/ipns/ipns_unix.go:249 +0x29e
  github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs.(*serveConn).serve()
      /Users/btc/Dropbox/src2/go/src/github.com/jbenet/go-ipfs/Godeps/_workspace/src/bazil.org/fuse/fs/serve.go:871 +0x63cf

btc pushed a commit that referenced this issue Nov 5, 2014
fix(race condition)
c897f91 
#270
btc pushed a commit that referenced this issue Nov 5, 2014
fix(bitswap_test) race cond
4566d43 
#270 (comment)
jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
ctx closer races #270
5386fba
jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
mux test race #270
78123a7
jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
fixed dht race #270
713dec0
btc pushed a commit that referenced this issue Nov 5, 2014
fix(race condition)
c764030 
#270
btc pushed a commit that referenced this issue Nov 5, 2014
fix(bitswap_test) race cond
308b5e4 
#270 (comment)
@btc
Copy link
Contributor Author

btc commented Nov 5, 2014

@jbenet full run-down

  • ipns_test (fixed in c897f91)
  • bitswap test (fixed in 4566d43)
  • spipe / closer
  • dht_test / closer
  • 1 merkledag
  • 2 merkledag
  • 3 merkledag

jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
ctx closer races #270
d26fd58
jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
mux test race #270
65f95a1
jbenet added a commit that referenced this issue Nov 5, 2014
@jbenet
fixed dht race #270
70f796a
@jbenet jbenet mentioned this issue Nov 5, 2014
Merged
@jbenet
Copy link
Member

jbenet commented Nov 5, 2014

(wasn't spipe after all, was sone weird goroutine stack re-scheduling)

@btc
Copy link
Contributor Author

btc commented Nov 5, 2014

Looks like you took down quite a few of the races. Is it clear from the checklist which ones?

@jbenet
Copy link
Member

jbenet commented Nov 5, 2014

not sure which are the merkledag ones yet. I have seen them in the past though. Will keep an eye out

btc pushed a commit that referenced this issue Nov 5, 2014
fix(race condition)
de61d66 
#270
btc pushed a commit that referenced this issue Nov 5, 2014
fix(bitswap_test) race cond
45b1929 
#270 (comment)
btc pushed a commit that referenced this issue Nov 5, 2014
Merge pull request #273 from jbenet/fix-data-races
9d7e0bb 
Fix data races in #270
@jbenet jbenet closed this as completed Jan 8, 2015
whyrusleeping pushed a commit to ipfs/go-bitswap that referenced this issue Jul 27, 2018
fix(bitswap_test) race cond
d3a79ef 
ipfs/kubo#270 (comment)
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@jbenet
fixed dht race ipfs#270
a45511b
@ajnavarro ajnavarro mentioned this issue Aug 24, 2022
Closed
72 tasks
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this issue Jan 26, 2023
fix(bitswap_test) race cond
86f5c72 
ipfs/kubo#270 (comment)


This commit was moved from ipfs/go-bitswap@d3a79ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @btc