Merge pull request #5433 from ipfs/test/gateway-options

improve gateway options test
ipfs · Sep 12, 2018 · cf96372 · cf96372
2 parents 7ad12bf + eabd6a0
commit cf96372
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/core/corehttp/gateway_test.go b/core/corehttp/gateway_test.go
@@ -128,9 +128,9 @@ func newTestServerAndNode(t *testing.T, ns mockNamesys) (*httptest.Server, *core
 
 	dh.Handler, err = makeHandler(n,
 		ts.Listener,
-		VersionOption(),
 		IPNSHostnameOption(),
 		GatewayOption(false, "/ipfs", "/ipns"),
+		VersionOption(),
 	)
 	if err != nil {
 		t.Fatal(err)
@@ -290,6 +290,23 @@ func TestIPNSHostnameRedirect(t *testing.T) {
 	} else if hdr[0] != "/good-prefix/foo/" {
 		t.Errorf("location header is %v, expected /good-prefix/foo/", hdr[0])
 	}
+
+	// make sure /version isn't exposed
+	req, err = http.NewRequest("GET", ts.URL+"/version", nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	req.Host = "example.net"
+	req.Header.Set("X-Ipfs-Gateway-Prefix", "/good-prefix")
+
+	res, err = doWithoutRedirect(req)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if res.StatusCode != 404 {
+		t.Fatalf("expected a 404 error, got: %s", res.Status)
+	}
 }
 
 func TestIPNSHostnameBacklinks(t *testing.T) {