Skip to content

Commit

Permalink
Merge pull request #8280 from ipfs/masih/test-issue-3503
Browse files Browse the repository at this point in the history
Add test with expected failure for #3503
  • Loading branch information
Stebalien authored Jul 21, 2021
2 parents 74bd44f + 1aa9c1a commit 050a281
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions test/sharness/t0055-dag-put-json-new-line.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#!/usr/bin/env bash

test_description='Test retrieval of JSON put as CBOR does not end with new-line'

. lib/test-lib.sh

test_init_ipfs

test_expect_success 'create test JSON files' '
WANT_JSON="{\"data\":1234}"
WANT_HASH="bafyreidcqah6v3py3ujdc3ris22rjlfntaw7ajrus2f2477kpnizulaoea"
printf "${WANT_JSON}\n" > with_newline.json &&
printf "${WANT_JSON}" > without_newline.json
'

test_expect_success 'puts as CBOR work' '
GOT_HASH_WITHOUT_NEWLINE="$(cat without_newline.json | ipfs dag put -f cbor)"
GOT_HASH_WITH_NEWLINE="$(cat with_newline.json | ipfs dag put -f cbor)"
'

test_expect_success 'put hashes with or without newline are equal' '
test "${GOT_HASH_WITH_NEWLINE}" = "${GOT_HASH_WITHOUT_NEWLINE}"
'

test_expect_success 'hashes are of expected value' '
test "${WANT_HASH}" = "${GOT_HASH_WITH_NEWLINE}"
test "${WANT_HASH}" = "${GOT_HASH_WITHOUT_NEWLINE}"
'

# Retrieval must not contain a new-line regardless of input JSON, because
# objects are put using the stable CBOR format.
# despite this, dag retrieval returns JSON with new-line.
# Expect failure until fixed, as per:
# - https://github.com/ipfs/go-ipfs/issues/3503#issuecomment-877295280
test_expect_failure "retrieval by hash does not have new line" '
ipfs dag get "${WANT_HASH}" > got.json
test_cmp without_newline.json got.json
'

test_done

0 comments on commit 050a281

Please sign in to comment.