Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused left-pad #30

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

iiska
Copy link
Contributor

@iiska iiska commented Oct 10, 2019

Remove unused left-pad dependency from package.json.

@iiska iiska changed the title Remove unused left-pad fix: Remove unused left-pad Oct 10, 2019
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iiska

Thanks for the PR. I will ask you for an unrelated change here. TLDR, we used to have a commitlint job in our repos, which has been problematic for new contributors because the CI fails and usually people don't know what is happening. As a result, we decided to remove the commitlint from CI and the maintainer should be responsible to guarantee that the commit message is properly written while merging the PR, through squash merge. FYI, in this case the CI is failing because it should be: fix: removed unused left-pad to be correct according to the standard commitlint rules.

Can you just remove this line please? With this, the CI will be green again and we will be able to proceed
https://github.com/ipfs/js-ipns/blob/master/.travis.yml#L23

Remove unused `left-pad` dependency from `package.json`.
Remove commitlint from `.travis.yml` as requested by @vasco-santos:
ipfs#30 (review)
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@vasco-santos vasco-santos merged commit 2ab0fbd into ipfs:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants