Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/change lead maintainer #274

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Jun 26, 2018

Following the discussion we had on slack, this PR add me as the lead maintainer.

Tasks as described here :

  • Update each package.json and README.md to have a leadMaintainer field.
  • Update packages table
  • Protect the master branch and only grant permissions for merge to the Maintainer and the Tech Lead, only.
  • Grant publish permission to the Maintainer and Tech Lead (or another Tech Lead if it’s the same person), only.

@ghost ghost assigned hugomrdias Jun 26, 2018
@ghost ghost added the status/in-progress In progress label Jun 26, 2018
@daviddias
Copy link
Member

Granted you perms to publish.

@hugomrdias
Copy link
Member Author

@diasdavid only thing missing is the master branch protection, but i don't have access to the repo settings.

Should i merge like this ?

@daviddias
Copy link
Member

@hugomrdias go for it. The master branch protection is on pause until a maintainer can do releases without being admin (because aegir does two git push to master by default).

@daviddias daviddias merged commit 50c2803 into master Jun 27, 2018
@ghost ghost removed the status/in-progress In progress label Jun 27, 2018
@daviddias daviddias deleted the chore/change-lead-maintainer branch June 27, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants