Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call 'close' only once when the process is killed #139

Closed
wants to merge 1 commit into from
Closed

Call 'close' only once when the process is killed #139

wants to merge 1 commit into from

Conversation

haadcode
Copy link
Member

@haadcode haadcode commented Dec 20, 2016 •
edited by dignifiedquire
Loading

Call close only was in order to avoid double callback when the process is killed.

@haadcode haadcode added the status/in-progress In progress label Dec 20, 2016
@dignifiedquire
Copy link
Member

@haadcode any idea why ci is unhappy?

@dignifiedquire
Copy link
Member

LGTM, CI will be happy once #140 is merged

@dignifiedquire
Copy link
Member

I pulled this into #140

@haadcode haadcode deleted the fix/close-once branch January 17, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haadcode @dignifiedquire @daviddias