This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ID command now generates a public key for output #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(browser): Use externals for node-forge
LGTM |
why is travis not running the tests? hmm.. investigating |
@@ -40,7 +45,6 @@ module.exports = function (config) { | |||
logLevel: config.LOG_INFO, | |||
autoWatch: false, | |||
browsers: process.env.TRAVIS ? ['Firefox'] : ['Chrome'], | |||
captureTimeout: 60000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we need to remove this?
LGTM. Not sure why travis didn't detect this PR, thoughts? |
Sorry accidentally removing the captureTimeout was causing it, good catch @diasdavid |
sweet! :D |
daviddias
added a commit
that referenced
this pull request
Feb 19, 2016
ID command now generates a public key for output
This was referenced May 25, 2021
This was referenced Jul 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.