This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
CLI - add block put flags and block get CID support
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
reviewed
Dec 10, 2016
| console.log(block.data.toString()) | ||
| // writing the buffer to stdout seems to be the only way | ||
| // to send out binary data correctly | ||
| process.stdout.write(block.data) |
daviddias
reviewed
Dec 10, 2016
| mhlen: { | ||
| describe: 'multihash hash length', | ||
| default: undefined | ||
| } |
There was a problem hiding this comment.
@whyrusleeping in what case is mhlength used ?
There was a problem hiding this comment.
we resolved this in the chats.
answer: why? idk, its in the spec
daviddias
suggested changes
Dec 10, 2016
| if (err) return cb(err) | ||
| mhash = _mhash | ||
| cb() | ||
| } |
There was a problem hiding this comment.
since you are doing waterfall, you can pass the cb directly to the block.key function and capture the hash in the waterfall sequence
There was a problem hiding this comment.
right - i previously needed the reference elsewhere, but that got factored out. will clean up.
kumavis
changed the title
block put flags and block get CID support
This was referenced Jun 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds flags to the
jsipfs block put <hash>commandformat(f)mhtypemhlenthese commands and their descriptions are based on go-ipfs https://github.com/ipfs/go-ipfs/blob/2aded6785dca9b8ce27595a9698d38ce993cbc5e/core/commands/block.go#L118-L121
This also adds support for CIDs in
ipfs block get <cid>and fixes the output of binary data