-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: examples/browser-create-react-app #3694
Conversation
This comment has been minimized.
This comment has been minimized.
@kvutien thank you! are you able to rebase this PR and fix CI errors? |
Thank you for the question but I'm afraid it's above my level of understanding. I'm a beginner and I just changed the README. It contained plenty of stuff from the original create-react-app README that are not relevant to this short demo. From my working notes of May, the rest of the code worked well enough straight as cloned, so I did not need to do changes. Congrats for using React hooks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries @kvutien, thanks for proof-reading and improving this example as a beginner, it is very valuable feedback 👍
I applied small changes to some sentences and added some links, but overall looks good to me.
FYI every example in this repo has tests that run on CI and here you can see the test failed because a label changed.
I fixed it and CI is now green.
examples/browser-create-react-app/src/hooks/use-ipfs-factory.js
Outdated
Show resolved
Hide resolved
examples/browser-create-react-app/src/hooks/use-ipfs-factory.js
Outdated
Show resolved
Hide resolved
Great. Thanks @lidel . Happy to help in anyway. On the other hand, I think that you are starting an interesting debate: should a tutorial facilitate the life of the developer team (project IPFS) or the life of the beginner? or of the evangelizer, almost beginner? 😉 for example...
My 2 cents... |
Thanks! Quick closing thoughts:
|
100% agree. Checking my working notes, I see that
I'd love to learn more about your CI. Is it in |
outdated (window.ipfs is no longer used) + we dont want to maintain it when the app gets refactored in the future
Co-authored-by: kvutien <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: kvutien <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
Hello
Thanks for this tutorial. I learned a lot from it.
create-react-app
that are not applicable here.Best.
Vu Tien Khang
Luxembourg