This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: ed25519 keys by default #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from RSA to ed25519 to match what we already do in go-ipfs.
It's the KeyType declared by libp2p-crypto, though on the CLI it should be the same as go-ipfs. |
achingbrain
approved these changes
Aug 11, 2021
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Switch from RSA to ed25519 to match what we already do in go-ipfs. Closes ipfs/js-ipfs#3591 Co-authored-by: achingbrain <[email protected]>
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is wip to switch from RSA to ed25519 to match what we already do in go-ipfs.
When merged, this should close #3591
TODO
ipfs initshould default to ed25519ipfs key genshould default to ed25519Ed25519(current js-ipfs) vsed25519(go-ipfs)? a typo or on purpose?./packages/ipfs-cli/src/commands/init.jshas@param {'RSA' | 'Ed25519' | 'secp256k1'} argv.algorithm