Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: fix types #3662

Merged
merged 4 commits into from
May 2, 2021
Merged

fix: fix types #3662

merged 4 commits into from
May 2, 2021

Conversation

achingbrain
Copy link
Member

Fix type errors exposed by integrating with powergate-client.

Fix type errors exposed by integrating with powergate-client.
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So bad that aegir ts checker does not get this

@achingbrain
Copy link
Member Author

inorite. Their tsc config did catch it so it must just be one of the options.

@achingbrain
Copy link
Member Author

I think it's because we have skipLibCheck: true in our aegir config. Turning that off reveals the errors this PR fixes but also errors in the types of modules outside our control 😭

@achingbrain achingbrain merged commit 0fe8892 into master May 2, 2021
@achingbrain achingbrain deleted the fix/fix-types branch May 2, 2021 08:00
This was referenced Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants