-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: update browser ipns publish example #3596
docs: update browser ipns publish example #3596
Conversation
This comment has been minimized.
This comment has been minimized.
Blocked until #2945 is done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mistery and apologies for a late review
I have two requests here:
- can you rebase this PR to fix the conflicts?
- can you update the Readme? The addresses in https://github.com/ipfs/js-ipfs/tree/master/examples/browser-ipns-publish#3-open-the-demo-in-a-browser-and-connect-to-the-go-node should be the websockets addrs as you added in the html file, not TCP as browsers do not speak tcp
5b1af29
to
db374af
Compare
@Gozala : are you able to check to see if this can be merged now? |
@mistery can you please rebase the PR with master as this seems to have a conflict now? |
db374af
to
16d904e
Compare
Co-authored-by: Vasco Santos <[email protected]>
Co-authored-by: Vasco Santos <[email protected]>
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @mistery
Hi @mistery, Thanks for your improvements, I was having problems connecting using web sockets and this did the trick. I just want to add one thing, it might be needed to change one line of code: From this, To: May be related to an update of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting on CI
Applying all the magic from #3584,
updating the dependencies,
adding tips (address example) for working with a local node