This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: validate ipns records with inline public keys #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially the twin of ipfs/kubo#7549 |
jacobheun
force-pushed
the
fix/ipns-inline-keys
branch
from
3b4ad65
to
5e33b53
Compare
|
@achingbrain I'm not sure why the browser tests are failing but I'm seeing the same failures in master from the release yesterday. Any ideas why these might be happening? |
|
I bumped ipfs-utils to include the reverted progress code which fixes the browser failures. |
vasco-santos
approved these changes
Aug 18, 2020
hugomrdias
approved these changes
Aug 18, 2020
Merged
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
* fix: validate with inline keys * test: check inlined pubkey support * chore: lock ipfs-utils at 2.3.1 * chore: test with ipfs-utils fix * chore: update ipfs-utils to 3.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPNS resolver was unnecessarily (and inaccurately) trying to fetch public keys from the network if they weren't embedded in the record. Embedding has been around for some time so we don't need this anymore.
This also fixes a problem where record validation wouldn't happen for inlined public keys. When PeerId's with inlined keys create ipns records, the public key is not embedded because this is duplicative. (this is the behavior of both Go and JS).
This was caught in interop testing of the latest go-ipfs updates to move to ed25519 keys by default. The failing job for this is https://app.circleci.com/pipelines/github/ipfs/go-ipfs/3329/workflows/33457111-bec0-46a9-80ef-f13fc7844231/jobs/38550.
related ipfs/kubo#7579