Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Make ipfs.files.add return DAGNodes #261

Closed
wants to merge 4 commits into from
Closed

Make ipfs.files.add return DAGNodes #261

wants to merge 4 commits into from

Conversation

hackergrrl
Copy link
Contributor

@hackergrrl hackergrrl commented May 23, 2016 •
edited
Loading

  • transform file tuples into DAGNodes
  • use + pass interface-ipfs-core tests for files.add

NOTE: this breaks backwards compatibility for add and will require a major semver bump.

@jbenet jbenet added the status/in-progress In progress label May 23, 2016
@hackergrrl hackergrrl changed the title Make ipfs.files.add returns DAGNodes. Make ipfs.files.add return DAGNodes May 23, 2016
@hackergrrl hackergrrl mentioned this pull request May 24, 2016
Closed
nginnever
nginnever reviewed May 25, 2016
View reviewed changes
src/core/ipfs/files.js
i.once('end', () => {
// Transform file info tuples to DAGNodes
i.pipe(through.obj(function transform (info, enc, next) {
console.log('info', info)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why console log in the core? What spec does this follow? Same for L31

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops -- debugging leftovers.

@hackergrrl
Copy link
Contributor Author

hackergrrl commented May 27, 2016 •
edited
Loading

This PR blocked on major release on https://github.com/ipfs/js-ipfs-unixfs-engine and merge of ipfs-inactive/interface-js-ipfs-core#20. Please don't merge until all is green. :)

@daviddias
Copy link
Member

@hackergrrl
Make ipfs.files.add return DAGNodes.
63be9f5
@hackergrrl
Rename unixfs output from 'stream' to 'content'.
5603e52
@hackergrrl
Mitigate test timing issues.
98667ad 
Though one of these is a fix (using 'before' properly), the rest are
timing issues that are more noticeable on slower computers.
@hackergrrl
Update ipfs-unixfs-engine to 0.9.0
7b698b3
@hackergrrl
Copy link
Contributor Author

Just waiting on ipfs-inactive/interface-js-ipfs-core#20 to get merged + published and we're good to go!

@daviddias
Copy link
Member

Did you check browser tests? Just ran them and got:

ERROR in ../interface-ipfs-core/test/files.js
Module build failed: Error: unsupported type for static module: VariableDeclarator
at expression:

fs = require('fs')

@nginnever
Copy link
Member

I got the same result when testing the interface-core tests through js-ipfs-api yesterday.

@dignifiedquire
Copy link
Member

that's a bug in brfs browserify/brfs#40

@daviddias daviddias mentioned this pull request Jun 5, 2016
Merged
@daviddias daviddias closed this Jun 5, 2016
@jbenet jbenet removed the status/in-progress In progress label Jun 5, 2016
@hackergrrl
Copy link
Contributor Author

@diasdavid sorry could you please share more information before closing a PR?

This was referenced Jan 9, 2021
Open
Open
Open
This was referenced Jan 21, 2022
Open
Open
This was referenced Mar 21, 2022
Open
Open
@zi3lak zi3lak mentioned this pull request Jun 22, 2022
Open
@internetbuilder internetbuilder mentioned this pull request Nov 29, 2023
Open
@rtpro rtpro mentioned this pull request Dec 6, 2023
Open
@thexdesk thexdesk mentioned this pull request Dec 7, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Dec 7, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hackergrrl @daviddias @nginnever @dignifiedquire @jbenet