This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: stop IPNS republisher ASAP #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the stop logic to perform stop actions in parallel for various components (where it is safe to do so). This means that libp2p gets stopped at the same time as the republisher. When libp2p stops it closes all connections meaning that the republsher is able to complete a running republish sooner. Before, we had to wait for republish to complete before stop happens (since there's no way to cancel a DHT put right now). License: MIT Signed-off-by: Alan Shaw <[email protected]>
ghost
assigned 
jacobheun
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
This looks good, just a note, this will not be a graceful shutdown of the republisher since all libp2p connections will be closed. Any in progress dht connections will also be ended and errored. Since the node is shutting down, this feels reasonable, especially since we have no mechanism to gracefully stop the dht currently.
vasco-santos
approved these changes
Apr 3, 2019
alanshaw
changed the title
alanshaw
changed the title
|
wow, did not expect this PR to cause this: 1) interface-ipfs-core over ipfs-http-client tests
.key.list
"after all" hook:
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\travis\build\ipfs\js-ipfs\test\node.js) |
dirkmc
approved these changes
Apr 3, 2019
added 3 commits
April 3, 2019 15:18
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
added 4 commits
April 4, 2019 09:55
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the stop logic to perform stop actions in parallel for various components (where it is safe to do so). This means that libp2p gets stopped at the same time as the republisher. When libp2p stops it closes all connections meaning that the republsher is able to complete a running republish sooner.
Before, we had to wait for republish to complete before stop happens (since there's no way to cancel a DHT put right now).