This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: files API #1720
Merged
refactor: files API #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs.
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
refactor/files-api
branch
from
5520b0e
to
df6182a
Compare
added 3 commits
November 20, 2018 09:18
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
ipfs/js-ipfs-repo#181 (comment) License: MIT Signed-off-by: Alan Shaw <[email protected]>
1 task
|
|
|
I agree that this is quite a breaking change. What do you think about a backwards-compatibility shim for a few versions with a DEPRECATED warning? Also, there are a few missed references that I ran into while investigating an unrelated issue: |
|
@dsmith3210 missed refs fixed in #1740 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of #1671 #1702 and #1719 allowing the files API changes to work with the ipld-dag-pb changes.
ipfs.addFrom*methods will be implemented in a separate PR.BREAKING CHANGE: Files API methods
add*,cat*,get*have moved fromfilesto the root namespace.Specifically, the following changes have been made:
ipfs.files.add=>ipfs.addipfs.files.addPullStream=>ipfs.addPullStreamipfs.files.addReadableStream=>ipfs.addReadableStreamipfs.files.cat=>ipfs.catipfs.files.catPullStream=>ipfs.catPullStreamipfs.files.catReadableStream=>ipfs.catReadableStreamipfs.files.get=>ipfs.getipfs.files.getPullStream=>ipfs.getPullStreamipfs.files.getReadableStream=>ipfs.getReadableStreamcloses #1671
closes #1702
closes #1719