Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: remove unused deps #1665

Merged
merged 2 commits into from
Oct 27, 2018
Merged

fix: remove unused deps #1665

merged 2 commits into from
Oct 27, 2018

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Oct 24, 2018 •
edited
Loading

This PR removes unused deps.

When this #1663 is merged, we will be able to use npm run dep-check -- --extra to check for unused packages

@ghost ghost assigned hugomrdias Oct 24, 2018
@ghost ghost added the status/in-progress In progress label Oct 24, 2018
@daviddias daviddias merged commit df32ac4 into master Oct 27, 2018
@ghost ghost removed the status/in-progress In progress label Oct 27, 2018
@daviddias daviddias deleted the fix/deps-check-extra branch October 27, 2018 19:56
@alanshaw
Copy link
Member

Has exposed this issue: ipfs/aegir#293

@hugomrdias
Copy link
Member Author

I'm on it

@hugomrdias hugomrdias mentioned this pull request Oct 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees

@hugomrdias hugomrdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugomrdias @alanshaw @daviddias