test: Remove CircleCI #1412
test: Remove CircleCI #1412
Conversation
ghost
assigned 
Since code coverage uploading now happens via Jenkins + CodeCov, no need to use CircleCI anymore! Also cleaned up some other files that are not used anymore License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
|
Also makes codecov show up properly as there is no failing CI left (if any CI is failing, codecov doesn't show report)
|
|
@victorbjelkholm while you are at it, can you do this to all the repos? 😇 (Specially js-ipfs-api, js-libp2p and js-ipld)? |
|
@diasdavid will update the badge :) Re doing this for all repos, CircleCI doesn't get disabled by removing the file but rather via the UI. I've talked with their support (since they don't offer unfollow via API and we have a lot of projects) and they can help us unfollow all projects at once from their side. Issue is that we cannot do this via PR, it'll be a action that is disconnected from the PR. As long as this is OK, we can do it everywhere at once :) |
|
@victorbjelkholm It's fine. Once all PRs are merged, I can go to Circle and do them all manually in one swipe super quick. |
|
|
||
| - [`interface-ipfs-core`](https://github.com/ipfs/interface-ipfs-core) | ||
| - [`http-api-spec`](https://github.com/ipfs/http-api-spec) | ||
| - [`cli spec`](https://github.com/ipfs/specs/tree/master/public-api/cli) |
There was a problem hiding this comment.
These are not included in the table anymore as they are not really packages but specifications. I did put interface-ipfs-core first as a part of the table, as it's actually more like a package, but then we're separating the specs, so put it back here.
There was a problem hiding this comment.
@diasdavid please check that the wording above is right before merging 👍
- Added a script for updating the package table in a easier maner. - Fixed some broken links (some still broken because not included in CI) - Removed extra whitespace in readme - Removed AppVeyor, TravisCI and CircleCI in favor of just Jenkins License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
| rows.map((row) => generateRow(row)).join('\n') | ||
| ] | ||
|
|
||
| toPrint.forEach((t) => console.log(t)) |
There was a problem hiding this comment.
@victorbjelkholm can you make this be a module that we can just feed it some JSON? It will get used by IPLD, and libp2p
There was a problem hiding this comment.
Let's put that as a future task, the scope of this PR is to remove CircleCI
|
|
||
| 'Generics/Utils', | ||
| ['ipfs/js-ipfs-api', 'ipfs-api'], | ||
| ['xicombd/ipfs-multipart', 'ipfs-multipart'], |
| ['ipfs/js-ipfs-block-service', 'ipfs-block-service'], | ||
| ['ipfs/js-ipfs-bitswap', 'ipfs-bitswap'], | ||
|
|
||
| 'Swarm/libp2p', |
There was a problem hiding this comment.
Gotta work on your escaping! Assumed you meant to replace this with just libp2p right?
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
| // Deps | ||
| (gh, npm) => `[](https://david-dm.org/${gh})`, | ||
| // DevDeps | ||
| (gh, npm) => `[](https://david-dm.org/${gh})`, |
There was a problem hiding this comment.
Thinking more about this, I say let's remove DevDeps. From the consumer standpoint, only deps matter.
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
True, missed that one. Then I'll switch all of them to CodeCov |
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
|
|
|
@diasdavid it was fixed in 3be0101
|
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
|
If only all those badges had square corners... 😛 |
Since code coverage uploading now happens via Jenkins + CodeCov, no need
to use CircleCI anymore!
Also cleaned up some other files that are not used anymore
License: MIT
Signed-off-by: Victor Bjelkholm [email protected]