This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: do not add newlines to object data #1352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned achingbrain
May 14, 2018
achingbrain
force-pushed
the
do-not-add-newlines-to-object-data
branch
from
May 14, 2018 11:13
718ba9b
to
c277ea0
Compare
daviddias
suggested changes
May 14, 2018
test/cli/object.js
Outdated
@@ -36,7 +36,7 @@ describe('object', () => runOnAndOff((thing) => { | |||
}) | |||
}) | |||
|
|||
it('put', () => { | |||
it.only('put', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove .only
before merging
achingbrain
force-pushed
the
do-not-add-newlines-to-object-data
branch
from
May 14, 2018 11:31
c277ea0
to
b91dbcc
Compare
fsdiogo
previously approved these changes
May 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
Please rebase master onto this branch for green CI |
achingbrain
force-pushed
the
do-not-add-newlines-to-object-data
branch
from
May 15, 2018 16:59
b91dbcc
to
d79e935
Compare
alanshaw
approved these changes
May 22, 2018
@diasdavid can you please approve this PR so it can be merged 🙏 |
daviddias
approved these changes
May 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with go-ipfs we should not add newlines to the output of
ipfs object data
.go:
js without this PR (with experimental mfs support) - note the extra
0a
at the end:js with this PR:
You may notice that the CIDs are different between go and js although the content is identical - this is because they structure the DAG differently for small files - js uses a single node if the data will fit in one node, go always creates one child that holds the data but this can be addressed in a separate PR.