-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
@fsdiogo I believe it makes sense to update the README and deliver the first iteration as being the revamp of the codebase to then later integrate the sync files. I say this considering the OKRs for Q2. |
@diasdavid just to clear things up, do you want me to update the readme considering these changes, and then open another PR implementing the file sync feature? I thought the file sync feature was part of this OKR. |
@diasdavid I've updated the README. Want me to work on the file sync feat in another branch? |
Exactly. There is a KR that is a P0 on your list and it should take priority. |
@diasdavid alright, I'll start working on that. When you have the time you can review this PR and I'll make the necessary changes so it can be merged. |
}) | ||
}) | ||
.catch((error) => onError('The inserted multihash is invalid.')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this return whatever error came from node.files.get(cid)
? This line seems to assume that the error is always that the multihash was wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it assumes the error is an invalid multihash. Before it was returning a stack trace, but in an example app like this I don't think that's the best solution.. neither one are to be honest.
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error handling is being handled by @hugomrdias . And after this work being completed, (there is a first PR for several commands, files is not one of them yet) we may forward the received error, since the stacktrace will only be received when in debug mode.
But until then, I think we should provide a friendlier message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, until then I can leave a more general message, something along the lines:
An error occurred when fetching the files.
What do you guys think?
@diasdavid I removed the start/stop button as we've talked when you were in Porto, it didn't make much sense, it was just cluttering the UI. I'm now starting the node as soon as the window opens and logging that so that the user knows what's happening. It got stuck probably because the ws-star server needs a reboot, I've already pinged @victorbjelkholm to do that. I'll change |
@fsdiogo perfect, I'll wait for @victorbjelkholm to give a kick to the Signalling endpoint so that we can fully test this tutorial. |
@fsdiogo, @victorbjelkholm fixed the issue with WebSockets but the node is still getting stuck on initializing for some reason. |
@diasdavid weird... it's working fine here! Can you please try again? |
@fsdiogo mind rebasing master onto this branch so that CI is green? |
0f77759
to
82d87bb
Compare
Done @diasdavid. |
1eff740
to
7b6d143
Compare
7b6d143
to
bd55179
Compare
@fsdiogo just came to mind that it would be super useful to have a progress bar for file uploads to ipfs. You can get the info with the option |
14e9dee
to
7283390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would like a review from @alanshaw as well :)
This PR is part of an OKR to level up the Exchange Files example.
Requirements:
Example:
Notes: