This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
docs: fix js dependencies in webpack example #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
Sep 22, 2017
| @@ -11,13 +11,17 @@ | |||
| "babel-core": "^6.24.1", | |||
| "babel-loader": "^7.0.0", | |||
| "babel-preset-react": "^6.24.1", | |||
| "babel-preset-stage-0": "^6.24.1", | |||
There was a problem hiding this comment.
Wha does the babel-preset-stage-0 do and why do we need it here?
There was a problem hiding this comment.
I'm not sure why it was included in the .babelrc https://github.com/ipfs/js-ipfs/blob/master/examples/browser-webpack/.babelrc
We can perhaps take that away if that wasn't needed too.
| "react-hot-loader": "^1.3.1", | ||
| "webpack": "^2.5.1", | ||
| "webpack-dev-server": "^2.4.5" | ||
| }, | ||
| "dependencies": { | ||
| "ipfs": "^0.26.0", |
There was a problem hiding this comment.
We still want to use IPFS from this repo - it needs to be something like:
"dependencies": {
"ipfs": "../../../src/core",
....
}
There was a problem hiding this comment.
This one should be correct
"dependencies": {
"ipfs": "file:../../",
}
daviddias
suggested changes
Oct 13, 2017
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| const React = require('react') | |||
| const Buffer = require('safe-buffer').Buffer | |||
| const IPFS = require('../../../../src/core') // replace this by line below | |||
| // const IPFS = require('ipfs') | |||
| // const IPFS = require('../../../../src/core') // replace this by line below | |||
There was a problem hiding this comment.
You can remove this line now.
|
@dryajov can you investigate and test if these changes are necessary? I've already run the examples just fine. |
|
looking into it! |
daviddias
previously approved these changes
Oct 22, 2017
ghost
removed
the
dryajov
pushed a commit
that referenced
this pull request
Oct 26, 2017
* docs: fix js dependencies in webpack example * Update app.js * Update package.json * Update package.json * Update package.json * Update app.js
This was referenced Jan 20, 2022
This was referenced Mar 21, 2022
This was referenced Aug 30, 2022
This was referenced Aug 30, 2022
This was referenced Aug 31, 2022
This was referenced Aug 31, 2022
This was referenced Jun 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example won't run unless these modules are installed.