Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

browser-script-tag example is broken and misleading #3027

Closed
npfoss opened this issue May 8, 2020 · 0 comments · Fixed by #3034
Closed

browser-script-tag example is broken and misleading #3027

npfoss opened this issue May 8, 2020 · 0 comments · Fixed by #3034
Labels
example exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/docs Documentation

Comments

@npfoss
Copy link
Contributor

npfoss commented May 8, 2020

  • Version: 0.43.3
  • Platform: Firefox
  • Subsystem: examples / cat

Severity: Medium

Description:

The in-browser example doesn't work any more.
The node loads fine, but if you add the cat example suggested, it totally fails and prints some stream object instead of "Hello world!".

I suspect this has been broken since the 0.41 update, and furthermore is a huge pain to fix.
I'm far from an expert, but I spent an hour trying to get it-concat or bl working via import from a script tag and couldn't figure it out.

Steps to reproduce the error:

Just run the example and add the suggested code snippet.

@npfoss npfoss added the need/triage Needs initial labeling and prioritization label May 8, 2020
achingbrain added a commit that referenced this issue May 14, 2020
Updates example syntax to new api, also removes references to
`dist/index.js` in favour of `dist/index.min.js`.

fixes #3027
@achingbrain achingbrain added example kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up topic/docs Documentation and removed need/triage Needs initial labeling and prioritization labels May 14, 2020
achingbrain added a commit that referenced this issue May 14, 2020
Updates example syntax to new api, also removes references to `dist/index.js` in favour of `dist/index.min.js`.

fixes #3027
oliveriosousa pushed a commit to oliveriosousa/js-ipfs that referenced this issue Jul 26, 2021
Updates example syntax to new api, also removes references to `dist/index.js` in favour of `dist/index.min.js`.

fixes ipfs#3027
SgtPooki referenced this issue in ipfs/js-kubo-rpc-client Aug 18, 2022
Updates example syntax to new api, also removes references to `dist/index.js` in favour of `dist/index.min.js`.

fixes #3027
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
example exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/docs Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants