fix: fix headers and abort signals #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for the same. Depends on: - [ ] ipfs/aegir#553
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
May 2, 2020
Somewhere along the line we stopped passing headers to the underlying request library which means people can't use http auth etc to try to secure their API servers. Fixes #3017 Depends on: - [ ] ipfs/js-ipfs-utils#41
1 task
hugomrdias
suggested changes
May 3, 2020
|
can you update aegir dep to merge this ? |
|
I think aegir still needs a release with ipfs/aegir#553 in it. |
chore: PR comments
achingbrain
force-pushed
the
fix/respect-headers
branch
from
e1562b7
to
6966db1
Compare
hugomrdias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the same.
Depends on: