Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove fixtures #117

Merged
merged 1 commit into from
Feb 17, 2021
Merged

chore: remove fixtures #117

merged 1 commit into from
Feb 17, 2021

Conversation

vmx
Copy link
Member

@vmx vmx commented Feb 17, 2021

No description provided.

@vmx vmx force-pushed the remove-unused-fixtures branch 2 times, most recently from 372e41b to 8da888c Compare February 17, 2021 12:30
@vmx vmx force-pushed the remove-unused-fixtures branch from 8da888c to 7069b0a Compare February 17, 2021 12:57
@vmx vmx requested a review from achingbrain February 17, 2021 13:05
@vmx
Copy link
Member Author

vmx commented Feb 17, 2021

@achingbrain This is ready to go. I made sure that the files in ipfs-unixfs-exporter/test and ipfs-unixfs-importer/test have the same structure as in the https://github.com/ipfs/js-ipfs-unixfs/tree/feat/add-types branch. Though I didn't take any types or other functional changes/fixes in this PR. This means that the file layout matches, but the contents is different.

I wouldn't expect a rebase of the add-types branch to be smooth, but a manual rebase with two checkouts and diffing between them manually shouldn't be too bad.

@achingbrain achingbrain merged commit 40e70a3 into master Feb 17, 2021
@achingbrain achingbrain deleted the remove-unused-fixtures branch February 17, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmx @achingbrain