[WIP] Move to pull-streams #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
| @@ -2,7 +2,7 @@ sudo: false | |||
| language: node_js | |||
| node_js: | |||
| - 4 | |||
| - 5 | |||
| - stable | |||
There was a problem hiding this comment.
why? it is just additional time, and I have not seen a single thing working in 4 & 6 that could break in 5
|
👍 for renaming things. Needs rebase, made some comments, then it is good to go :) |
|
@diasdavid ready :) |
blockstore and datastore-legacy -> datastore + use base32 encoding for blocks BREAKING: - Rename `datastore` to `blockstore` and `datastore-legacy` to `datastore`. - Stores now need to adhere to the [interface-pull-blob-store](https://github.com/ipfs/interface-pull-blob-store) definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newly created interface-pull-blob-store with the
fsandidimplementations. The interface remains the same, except the renaming ofdatastore- >blockstoredatastore-legacy- >datastoreThis also fixes #67 and is as such a breaking change, but can be mitigated using
fs-repo-migrationsfor fs nodes.