This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
chore: callbacks -> async / await #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can reproduce the test failures from Travis locally. |
|
There are a couple of things that need to be fixed in the dependencies before the tests will pass - see eg ipfs/js-ipfs-repo#189 (comment) |
|
@dirkmc Please review my changes. If you're OK with them, I'll do a force push having a single commit only. Thanks for the original PR! :) |
|
LGTM 👍 Note: I can't approve the changes as I opened the PR :) |
This is part of the Awesome Endeavour: Async Iterators ipfs/js-ipfs#1670 BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
|
Just squashed the commit that was already reviewed. Hence merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
Depends on