Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pull streams #25

Merged
merged 1 commit into from
Sep 9, 2016
Merged

[WIP] Pull streams #25

merged 1 commit into from
Sep 9, 2016

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Aug 21, 2016

  • New pull-stream based interface used in js-ipfs-block-service
  • Tests passing with all deps moved to pull-streams
  • Modular async
  • replace highland.js with pull-stream

@@ -2,7 +2,7 @@ sudo: false
language: node_js
node_js:
- 4
- 5
- stable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add Node.js 5 too

@daviddias
Copy link
Member

I would appreciate (and all of the contributors) if there was some documentation explaining how bitswap works internally, currently it requires to dig through the code to confirm every detail.

@dignifiedquire
Copy link
Member Author

Latest failure seems only due to browserify-zlib not being the right version

@daviddias
Copy link
Member

@dignifiedquire #25 (comment) why is this a problem only in js-ipfs-bitswap?

- pull-streams
- remove highland
- update deps
@dignifiedquire
Copy link
Member Author

Tests are actually passing on travis, for some reason though aegir doesn't agree with that -.-

@dignifiedquire dignifiedquire merged commit 1f18434 into master Sep 9, 2016
@dignifiedquire dignifiedquire removed the status/in-progress In progress label Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants