This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: types #62
Merged
feat: types #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds types support
|
ready |
achingbrain
reviewed
Jan 22, 2021
achingbrain
approved these changes
Jan 22, 2021
achingbrain
reviewed
Jan 22, 2021
| strategy: | ||
| matrix: | ||
| os: [windows-latest, ubuntu-latest, macos-latest] | ||
| node: [12, 14] |
There was a problem hiding this comment.
Suggested change
| node: [12, 14] | |
| node: [14, 15] |
This should be 14 & 15 as that's LTS/Current. Going through and updating all of these repos every time there's a new node version is going to be an enormous pain, can it be automated?
There was a problem hiding this comment.
There was a problem hiding this comment.
That issue looks like it's stalled and the linked PR is stale and also contains a bunch of irrelevant changes which will harm its chances of being merged.
I think we'll need to do something ourselves for the time being.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types support