Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove redux-bundler, full typescript #448

Merged
merged 52 commits into from
Oct 17, 2024
Merged

feat!: remove redux-bundler, full typescript #448

merged 52 commits into from
Oct 17, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 24, 2024

  • feat: convert to typescript and remove redux-bundler
  • feat: fetching is working

This is still in progress, but I wanted to get something out

Motivation: After we migrate to typescript and remove all redux-bundler, it will make it much easier to update vite, storybook, react, etc...

Summary of important changes:

  • Removed redux-bundler. consumers should use context providers and hooks now
    • updated usage guide
  • converted all code to typescript
  • removed react-virtualized as it's old, huge, and requires patches in bundler. new links-table looks slightly different, but we can iterate if there are issues.
  • storybook updated to latest versions
  • vite updated to latest versions
  • all deps updated to latest versions
  • import paths are supported now so folks can import only what they want (i.e. heliaProvider.. which should be pulled out into it's own lib eventually)

Things still needing addressed:

MVP

  • breadcrumb link clicking doesn't work great: appends / every time you click the first child (not the root CID, the first child/link of that CID)
  • deeplinking (going into an explore link without landing on home page first) doesn't seem to work properly
  • Fix ExplorePage story (only showing loading spinner: confirm this was occurring before, or fix) -- it was only a loading spinner before.
  • Storybook build fails in CI but not in local build: https://github.com/ipfs/ipld-explorer-components/actions/runs/11041253271/job/30671117910?pr=448#step:4:118
  • Update usage guide
  • convert tests from .test.js to .test.ts

Others

  • convert all storybook stories to typescript

@SgtPooki SgtPooki marked this pull request as ready for review October 17, 2024 21:42
@SgtPooki SgtPooki requested a review from a team as a code owner October 17, 2024 21:42
@SgtPooki SgtPooki merged commit eeb15ec into master Oct 17, 2024
16 checks passed
@SgtPooki SgtPooki deleted the feat/overhaul branch October 17, 2024 21:42
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
## [8.0.0](v7.0.3...v8.0.0) (2024-10-17)

### ⚠ BREAKING CHANGES

* remove redux-bundler, full typescript (#448)

### Features

* remove redux-bundler, full typescript ([#448](#448)) ([eeb15ec](eeb15ec)), closes [#449](#449)

### Tests

* validate remainder path ([#449](#449)) ([7748e75](7748e75))
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant