fix: skip window.ipfs #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web UI wants all the privileges. With window.ipfs the files view gets silo'd to the files added _in this origin_ so it's gonna cause confusion. This PR updates thing to use the new ipfs-redux-bundle and skips window.ipfs in the provider checks. Also adds an identity bundle as we no longer use /id as the ipfs connection test, to move us towards supporting the read-only api where it is all that is available. License: MIT Signed-off-by: Oli Evans <[email protected]>
lidel
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Tested with ipfs-inactive/ipfs-redux-bundle#15 and works as expected 👍
Small nitpick:
Previously, window.ipfs was a link to companion repo, but the new label is no longer clickable:
Was that on purpose, or just lost in refactor? I think it was quite useful, hinting at users to learn more etc ;)
|
Good point! I need to update the providers list. |
|
@olizilla I'm just wondering: going directly to IPFS Companion's instance of IPFS is easy. Won't other apps be able to do the same? |
|
@hacdias the "direct from companion" option only works if your app as been bundled with companion. |
|
@olizilla awesome then 😄 |
also add provider info for ipfs-companion License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
commented
Oct 4, 2018
License: MIT Signed-off-by: Oli Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on
Web UI wants all the privileges. With window.ipfs the files view
gets silo'd to the files added in this origin so it's gonna
cause confusion.
This PR updates thing to use the new ipfs-redux-bundle and skips
window.ipfs in the provider checks.
Also adds an identity bundle as we no longer use /id as the
ipfs connection test, to move us towards supporting the read-only
api where it is all that is available.
fixes #787
fixes #837
License: MIT
Signed-off-by: Oli Evans [email protected]