Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update hint text in browse bar #1638

Merged
merged 2 commits into from
Sep 17, 2020
Merged

chore: update hint text in browse bar #1638

merged 2 commits into from
Sep 17, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Sep 16, 2020 •
edited
Loading

As mentioned in #1636 (comment):

In the search bar on top "Qmhash" should be switched to "bafyHash" or "IPFS CID" or "CID"?

This PR adds a reference to bafy hashes as depicted below. Happy to haggle over the text.

image

@jessicaschilling jessicaschilling added this to the v2.12 milestone Sep 16, 2020
@jessicaschilling jessicaschilling mentioned this pull request Sep 16, 2020
Closed
@jessicaschilling jessicaschilling merged commit 190b57d into master Sep 17, 2020
@jessicaschilling jessicaschilling deleted the chore/update-hash-prompt branch September 17, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelramalho19 rafaelramalho19 rafaelramalho19 approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.13
Development

Successfully merging this pull request may close these issues.
3 participants
@jessicaschilling @lidel @rafaelramalho19