Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): sync app.json and notify.json #1637

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix(i18n): sync app.json and notify.json #1637

merged 2 commits into from
Sep 16, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 16, 2020 •
edited
Loading

This ensures translations for app.json and notify.json will be fetched when tx pull -a is executed and translation is at least 75% complete.

Closes #1636

@lidel
fix(i18n): sync notify-json
b0c426e 
It also ensures new language will have proper mapping when someone
submits translations
@lidel lidel changed the title fix(i18n): sync app.json fix(i18n): sync app.json and notify.json Sep 16, 2020
jessicaschilling
jessicaschilling approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidel lidel merged commit d755149 into master Sep 16, 2020
@lidel lidel deleted the fix/app-json branch September 16, 2020 22:21
@internetbuilder internetbuilder mentioned this pull request Oct 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelramalho19 rafaelramalho19 rafaelramalho19 approved these changes

@jessicaschilling jessicaschilling jessicaschilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible translation regression since last published version v2.10.2
3 participants
@lidel @jessicaschilling @rafaelramalho19