add logic to build and publish a tarball on release #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olizilla -- may I send this your way to look over or send along? Thanks! |
olizilla
requested changes
Jul 10, 2020
.github/workflows/publish_build.yml
Outdated
| tar -czf ipfs-webui.tar.gz build/* | ||
|
|
||
| - name: Copy build-artifacts to Release | ||
| uses: skx/github-action-publish-binaries@master |
There was a problem hiding this comment.
Please pin skx/github-action-publish-binaries to a specific version
There was a problem hiding this comment.
Sorry missed this comment pinned to @release-0.14
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to consume this software downstream for a Docker image, but the build process is a bit heavy.
This logic pushes a tarball to a release when published.
You can see an example on my fork here:
https://github.com/thelamer/ipfs-webui/releases/tag/v2.10.2
https://github.com/thelamer/ipfs-webui/runs/855791405?check_suite_focus=true
You don't need to setup anything on the repo, merging this will push tarballs for all subsequent releases made after merge.
I understand the value of pushing stuff like this to IPFS but in the case of software ingestion from your repo, the whole world conventionally hits the latest release api on github and pulls in on new release tags. Having this build asset transparently built in Github greatly simplifies this process.
Let me know if you have any questions.