-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files: issues when browsing /ipfs/{cid} #1665
Comments
I figured these were minor enough as I discovered them to group here, I can parse into separate issues if you see fit 🙏🏼 |
(Transferring issue to webui repo.) |
Thanks, @nukemandan. We'll investigate these in more depth in our next weekly triage. |
Some notes for triage:
|
Per ipfs/ipfs-webui#1665, make instructions for logs clearer for Linux users who don't see a system tray menu.
* Update bug report template Per ipfs/ipfs-webui#1665, make instructions for logs clearer for Linux users who don't see a system tray menu. * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Marcin Rataj <[email protected]> Co-authored-by: Marcin Rataj <[email protected]>
RE: bug 1 - this is expected behaviour I think, as a raw CID does not contain file header information like a file that has human readable MFS extensions... I would think it possible to auto detect this in browser, I know that on Linux at least, with no extension the OS usually detects the file type somehow... RE: bug 4 - I actually do have the tray icon! But I did not realize that was where I was to look! I was only trying to find this in the full window GUI. The error logs seem to indicate updating automatically is not working, possibly only due to the updater not being installed correctly by my or the .deb package? (Revision 7a8f695) |
I updated to v0.13.0 via the .deb release and have the same updating error. I can port this to a new issue if you like 😁 |
@nukemandan - An updating issue would be specific to Desktop, so if you're able to open an issue in https://github.com/ipfs-shipyard/ipfs-desktop with any relevant details, that would be very helpful. |
Thank you @nukemandan! Did a quick analysis of Problem occurs because ipfs-webui does not do full-blown proper content-type sniffing, it only looks at filename https://github.com/ipfs-shipyard/ipfs-webui/blob/95319bab6e1d915bff1d83717752ec2f8312f715/src/files/file-preview/FilePreview.js#L21 That is why opening https://webui.ipfs.io/#/ipfs/Qmdgqdddt3F2uszEaE7zph7kXbwHX3iTDCWeQjdtNGnQgz fails because it has no file extension to work with. Quick fix would be to add More robust fix would be to detect situation like this, read first |
Happy to craft separate issues referencing this one and closing it if that helps @lidel 🙇🏼 |
.txt
file extention
For this specific case I think we can keep them grouped together (renamed the issue to reflect that) 👍 |
need to repro bugs again to confirm issues after the merging of #1894 |
Describe the bug
I am looking at the Apollo archive (listed in the explore tab) at this image (on my local gateway)
http://127.0.0.1:8080/ipfs/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDEwIE1hZ2F6aW5lIDM1L1U=/21328560323_6b33f5d4c3_o.jpg
In the explore tab I also navigated to find the raw CID of the image, which is here (
Qmdgqdddt3F2uszEaE7zph7kXbwHX3iTDCWeQjdtNGnQgz
):http://127.0.0.1:8080/ipfs/Qmdgqdddt3F2uszEaE7zph7kXbwHX3iTDCWeQjdtNGnQgz
Bug 1:
Using the Brose search bar up top for that CID gives:
The "Try downloading it instead." link correctly gives a .jpeg extension.
Bug 2:
BUT the
... More
menu download yields a "Save As..." menu with a .txt file named the CID.Bug 3:
I try to pin/unpin this to my node in the same menu, and receive an error:
Bug 4 😉
I can't find this on the GUI anywhere, though I am directed to by the issue template:
I only found the attached logs as I get the notification when I run the application from a terminal
combined.log
error.log
The text was updated successfully, but these errors were encountered: