Capitalized, clean up #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
added
exp/novice
|
@RichardLitt you broke my tests! |
|
...hooray? I'm guessing you want me to fix those, too? |
|
probably, yeah. Its just adjusting the expected message in the test thats failing |
|
Tests were having other problems too (see #34) |
RichardLitt
force-pushed
the
feature/doc-fixes
branch
from
a3ff664
to
69d664b
Compare
|
I removed all uppercase and final periods for |
|
@RichardLitt could you rebase this on master? |
RichardLitt
force-pushed
the
feature/doc-fixes
branch
from
69d664b
to
a1a49b2
Compare
|
@whyrusleeping Done. |
|
@RichardLitt youre gonna have to update the tests since you changed the output theyre checking against. |
RichardLitt
force-pushed
the
feature/doc-fixes
branch
from
a1a49b2
to
bb050f8
Compare
|
@whyrusleeping Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.