fix: use correct config path during development #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes electron to read package.json and other config correctly, so configuration is read from ~/.config/IPFS Desktop instead of ~/.config/Electron, so npm start behaves closer to production. License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
requested review from
olizilla,
jessicaschilling,
hacdias and
rafaelramalho19
jessicaschilling
approved these changes
Oct 9, 2020
License: MIT Signed-off-by: Marcin Rataj <[email protected]>
hacdias
approved these changes
Oct 10, 2020
|
I think you repeated yourself with "~/.config/IPFS Desktop instead of ~/.config/IPFS Desktop", did you mean: |
|
@rafaelramalho19 correct – i fixed PR description, thanks! |
rafaelramalho19
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes instance started via
npm startreadpackage.jsonand that makes Electron to use config from~/.config/IPFS Desktopinstead of~/.config/Electron.Goal here is to have the same behavior in dev as in packaged production version, reducing the surface for human error (eg. I was removing
~/.config/IPFS Desktopbetween tests while~/.config/Electronremained with broken config)@hacdias @olizilla cc fyi (I remember this being an issue in past, this seems to be the fix)