feat: update ipfsd-ctl to 4.x #1411

hacdias · 2020-04-17T11:39:43Z

Superseeds #1302. Closes #1412.

I'm starting this on a new branch with the version 3.x. I'm using a lot o @lidel's work on that PR.

hacdias · 2020-04-17T14:08:32Z

Seems to fail only on AppVeyor. It does seem to be something to do with the output parsing. For some reason I'm not being able to download Electron dep on Windows (too slow, networking issues?) right now.

Update: can reproduce errors (tests) on Windows!

hacdias · 2020-04-17T15:16:25Z

@lidel it seems the tests failed on Windows because of some beautiful characters known as CR. .trim() seems to have solved the issue.

lidel · 2020-04-17T22:24:31Z

I'll take a look at this as soon as I figure out how to get tray icon back (#1153) 🙃

hacdias · 2020-04-18T18:28:50Z

Just upgraded some files where I saw the API changed. Completely missed those!

hacdias · 2020-04-20T20:28:32Z

Update to 4.x blocked: ipfs/js-ipfsd-ctl#501

lidel · 2020-04-21T00:32:55Z

@hacdias should be fixed in js-ipfsd-ctl v4.0.1 – mind taking a look?
(We need the fixed support for IPFS_PATH that comes with 4.x)

hacdias · 2020-04-21T07:32:26Z

@lidel seems to be working!

License: MIT Signed-off-by: Henrique Dias <[email protected]>

This fixes a bug when local ipfsd.stop() was called even when no IPFS_PATH/config was present. License: MIT Signed-off-by: Marcin Rataj <[email protected]>

License: MIT Signed-off-by: Henrique Dias <[email protected]>

hacdias · 2020-04-22T09:08:35Z

Just rebased on top of master

lidel

I did some smoke tests and looks ok.
@hacdias feel free to merge it (API improvements are really important, sooner we have them the better)

ps. found unrelated UX issue, but filled #1436 for that.

lidel · 2020-04-17T23:24:24Z

src/daemon/index.js

@@ -78,21 +78,19 @@ module.exports = async function (ctx) {
    const log = logger.start('[ipfsd] stop daemon', { withAnalytics: 'DAEMON_STOP' })
    updateStatus(STATUS.STOPPING_STARTED)

-    if (!fs.pathExists(join(ipfsd.repoPath, 'config'))) {
+    if (!fs.pathExistsSync(join(ipfsd.path, 'config'))) {


@hacdias pathExists returns a promise, FYSA I fixed this (247b3a8) to use pathExistsSync instead

Oopsie. I knew that but completely missed. Probably forgot adding an await. Thanks!

guanzo · 2022-02-18T23:22:30Z

src/daemon/config.js

-  const freeGatewayPort = await portfinder.getPortPromise({ port: gatewayPort, stopPort: gatewayPort + 100 })
-  const freeApiPort = await portfinder.getPortPromise({ port: apiPort, stopPort: apiPort + 100 })
+  const findFreePort = async (port, from) => {
+    port = Math.max(port, from, 1024)


Hello, this Math.max call prevents me from setting a gateway port lower than 8080, and an api port lower than 5001. When I edit the config file and restart ipfs-desktop, it says the port is busy and suggests a new one.

For example if I try to set gateway port to 6437, then

const gatewayPort = 6437 // read from config file const freeGatewayPort = await findFreePort(gatewayPort, 8080) // returns 8080 // evaluates to true, even though 6437 is free. const busyGatewayPort = gatewayPort !== freeGatewayPort // I get a popup saying "The port 6437 is not available. Do you want to use 8080 instead?"

hacdias changed the title ~~Feat/ipfsd ctl update~~ feat: update ipfs controller Apr 17, 2020

hacdias mentioned this pull request Apr 17, 2020

feat: new ctl #1302

Closed

hacdias changed the title ~~feat: update ipfs controller~~ feat: update ipfsd-ctl Apr 17, 2020

hacdias changed the title ~~feat: update ipfsd-ctl~~ feat: update ipfsd-ctl to 3.x Apr 17, 2020

hacdias force-pushed the feat/ipfsd-ctl-update branch from 3f83090 to 9d1de70 Compare April 17, 2020 13:24

hacdias force-pushed the feat/ipfsd-ctl-update branch from c19a4a4 to 5daa783 Compare April 17, 2020 15:17

hacdias requested a review from lidel April 17, 2020 15:20

hacdias marked this pull request as ready for review April 17, 2020 15:21

hacdias mentioned this pull request Apr 17, 2020

Release 0.11.0 #1415

Closed

22 tasks

hacdias force-pushed the feat/ipfsd-ctl-update branch from 5daa783 to b952985 Compare April 17, 2020 19:53

lidel mentioned this pull request Apr 17, 2020

feat: run garbage collector #1407

Merged

hacdias mentioned this pull request Apr 18, 2020

feat: allow custom ipfs binary #1427

Merged

hacdias force-pushed the feat/ipfsd-ctl-update branch from 7b75895 to 2e5989d Compare April 20, 2020 20:28

lidel mentioned this pull request Apr 21, 2020

POST-only HTTP API ipfs/js-ipfs#2971

Closed

2 tasks

hacdias force-pushed the feat/ipfsd-ctl-update branch from 2e5989d to f68388f Compare April 21, 2020 07:15

hacdias changed the title ~~feat: update ipfsd-ctl to 3.x~~ feat: update ipfsd-ctl to 4.x Apr 21, 2020

hacdias mentioned this pull request Apr 22, 2020

feat(ux): improve download cid #1419

Merged

hacdias force-pushed the feat/ipfsd-ctl-update branch from f68388f to 30d5ab2 Compare April 22, 2020 07:27

hacdias and others added 5 commits April 22, 2020 08:58

feat: use ipfsd-ctl 3.x

3454085

License: MIT Signed-off-by: Henrique Dias <[email protected]>

fix: don't kill daemon when remote API is used

247b3a8

This fixes a bug when local ipfsd.stop() was called even when no IPFS_PATH/config was present. License: MIT Signed-off-by: Marcin Rataj <[email protected]>

fix: new api on gc

5c0fbe8

License: MIT Signed-off-by: Henrique Dias <[email protected]>

fix: add to ipfs use new api

ae88dac

License: MIT Signed-off-by: Henrique Dias <[email protected]>

fix: download hash uses new api

6ceb02e

License: MIT Signed-off-by: Henrique Dias <[email protected]>

feat: ipfsd-ctl 4.x

aa78dd4

hacdias force-pushed the feat/ipfsd-ctl-update branch from 30d5ab2 to aa78dd4 Compare April 22, 2020 07:59

lidel approved these changes Apr 22, 2020

View reviewed changes

lidel mentioned this pull request Apr 22, 2020

feat: support for go-ipfs 0.5 #1392

Merged

1 task

hacdias merged commit a32b295 into master Apr 23, 2020

hacdias deleted the feat/ipfsd-ctl-update branch April 23, 2020 07:01

guanzo reviewed Feb 18, 2022

View reviewed changes

hacdias mentioned this pull request Feb 24, 2022

Cannot Set Gateway / API Ports Lower Than 8080 / 5001 #1990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update ipfsd-ctl to 4.x #1411

feat: update ipfsd-ctl to 4.x #1411

hacdias commented Apr 17, 2020 •

edited

Loading

hacdias commented Apr 17, 2020 •

edited

Loading

hacdias commented Apr 17, 2020

lidel commented Apr 17, 2020

hacdias commented Apr 18, 2020

hacdias commented Apr 20, 2020

lidel commented Apr 21, 2020 •

edited

Loading

hacdias commented Apr 21, 2020

hacdias commented Apr 22, 2020

lidel left a comment

lidel Apr 17, 2020 •

edited

Loading

hacdias Apr 23, 2020

guanzo Feb 18, 2022 •

edited

Loading

feat: update ipfsd-ctl to 4.x #1411

feat: update ipfsd-ctl to 4.x #1411

Conversation

hacdias commented Apr 17, 2020 • edited Loading

hacdias commented Apr 17, 2020 • edited Loading

hacdias commented Apr 17, 2020

lidel commented Apr 17, 2020

hacdias commented Apr 18, 2020

hacdias commented Apr 20, 2020

lidel commented Apr 21, 2020 • edited Loading

hacdias commented Apr 21, 2020

hacdias commented Apr 22, 2020

lidel left a comment

Choose a reason for hiding this comment

lidel Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

hacdias Apr 23, 2020

Choose a reason for hiding this comment

guanzo Feb 18, 2022 • edited Loading

Choose a reason for hiding this comment

hacdias commented Apr 17, 2020 •

edited

Loading

hacdias commented Apr 17, 2020 •

edited

Loading

lidel commented Apr 21, 2020 •

edited

Loading

lidel Apr 17, 2020 •

edited

Loading

guanzo Feb 18, 2022 •

edited

Loading