Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced → "Open [..] directory" cause fatal crash #1676

Closed
jessicaschilling opened this issue Oct 7, 2020 · 2 comments · Fixed by #1687
Closed

Advanced → "Open [..] directory" cause fatal crash #1676

jessicaschilling opened this issue Oct 7, 2020 · 2 comments · Fixed by #1687
Assignees
@lidel
Labels
area/linux Linux area/macos MacOS effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P0 Critical: Tackled by core team ASAP
Milestone
v0.13.1

Comments

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Oct 7, 2020 •
edited
Loading

I'm repeatedly killing Desktop when trying to select the following options under Advanced:

  • Open Logs Directory
  • Open Repository Directory
  • Open Configuration File

Specifications

  • OS: darwin
  • IPFS Desktop Version: 0.13.0
  • Electron Version: 9.3.2
  • Chrome Version: 83.0.4103.122

Error

TypeError: shell.openItem is not a function
    at click (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/tray.js:141:32)
    at MenuItem.click (electron/js2c/browser_init.js:65:1624)
    at Function.executeCommand (electron/js2c/browser_init.js:73:1102)
@jessicaschilling jessicaschilling added the need/triage Needs initial labeling and prioritization label Oct 7, 2020
@jessicaschilling jessicaschilling mentioned this issue Oct 7, 2020
Open
@lidel
Copy link
Member

lidel commented Oct 7, 2020

I can confirm the same error on Linux.

Specifications

  • OS: linux
  • IPFS Desktop Version: 0.13.0
  • Electron Version: 9.3.2
  • Chrome Version: 83.0.4103.122

Error

TypeError: shell.openItem is not a function
    at click (/home/lidel/tmp/test-13/ipfs-desktop-0.13.0-rc3/ipfs-desktop-0.13.0-linux-x64/resources/app.asar/src/tray.js:141:32)
    at MenuItem.click (electron/js2c/browser_init.js:65:1624)
    at Function.executeCommand (electron/js2c/browser_init.js:73:1102)

@lidel lidel added area/linux Linux area/macos MacOS exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Oct 7, 2020
@lidel lidel changed the title Fatal crash when trying to open directories Advanced → "Open [..] directory" cause fatal crash Oct 7, 2020
@lidel lidel mentioned this issue Oct 7, 2020
Merged
6 tasks
@lidel
Copy link
Member

lidel commented Oct 7, 2020

Potential duplicate: #1677

@nuke-web3 nuke-web3 mentioned this issue Oct 8, 2020
Closed
@lidel lidel added this to the v0.13.1 milestone Oct 9, 2020
@lidel lidel self-assigned this Oct 9, 2020
@lidel lidel mentioned this issue Oct 9, 2020
Merged
@lidel lidel mentioned this issue Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/linux Linux area/macos MacOS effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
v0.13.1
Development

Successfully merging a pull request may close this issue.

fix: openItem errors ipfs/ipfs-desktop
2 participants
@lidel @jessicaschilling