fix: Improve extraHeaders feature detection #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox forks the
runtime.isFirefoxdetection will fail (because the browser name is not 'Firefox'). This leads to an error when registering webRequest listeners as theextraHeadersoption is not needed, preventing the extension from loading.There is actually an extension API that can be used to detect support for this option:
OnBeforeSendHeadersOptions.This PR updates the feature detection check to explicitly look for this API. We have to also check to for the presence of
OnBeforeSendHeadersOptionsas it does not exist on Edge.