fix: window.ipfs streaming #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kground, and upgrade ipfs-postmsg-proxy with fix for pull-postmsg-stream
lidel
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
LGTM.
@alanshaw Does it solve issues raised by @olizilla ?
Should we ship a new beta with this fix?
|
Both js-ipfs-api and (to some extent) js-ipfs have bugs that prevent adding files with pull streams: |
This was referenced Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues at play here:
pull-postmsg-streamwas using an old version ofpostmsg-rpcso wasn't getting the data from a message correctly and caused it to error when pulling over web extension port messaging