Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): ⬇️ Reduce event syncs #1296

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix(telemetry): ⬇️ Reduce event syncs #1296

merged 2 commits into from
Sep 25, 2023

Conversation

whizzzkid
Copy link
Contributor

5mins -> 60mins

@whizzzkid whizzzkid requested review from lidel and a team as code owners September 25, 2023 14:38
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but if we have a local persistence, is there a reason why we don't bump it even higher, and flush events to courtly only during extension start + once a day or once a week?

Signed-off-by: Nishant Arora <[email protected]>
@whizzzkid
Copy link
Contributor Author

@lidel the local persistence is only in the memory, I can restructure to save it to local storage as a follow-up.

@SgtPooki
Copy link
Member

Agree 100% with Lidel on persistence, and also reducing event emission to weekly.

Also, we should confirm in countly that the events from 1 particular user are actually being sent at the interval we expect (could be a bug?)

@whizzzkid whizzzkid merged commit 6326cdb into main Sep 25, 2023
5 checks passed
@whizzzkid whizzzkid deleted the fix/event-syncs branch September 25, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants