Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moving from ipfs-http-client -> kubo-rpc-client #1124

Merged
merged 2 commits into from
Jan 3, 2023
Merged

feat: Moving from ipfs-http-client -> kubo-rpc-client #1124

merged 2 commits into from
Jan 3, 2023

Conversation

whizzzkid
Copy link
Contributor

Closes: #1120

In this PR:

  • the build seems to work with a drop-in replacements
  • removed other unused packages
  • since we bundle this, we need this as a dev desp.

hacdias
hacdias approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine, as the API calls have not been changed.

@whizzzkid whizzzkid merged commit d439a97 into main Jan 3, 2023
@whizzzkid whizzzkid deleted the feat/kubo-rpc-client branch January 3, 2023 19:21
This was referenced Feb 3, 2023
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@lidel lidel Awaiting requested review from lidel lidel is a code owner

@meandavejustice meandavejustice Awaiting requested review from meandavejustice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from ipfs-http-client -> kubo-rpc-client
2 participants
@whizzzkid @hacdias